On Tue, Mar 8, 2011 at 8:50 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Mar 08, 2011 at 05:50:45PM -0800, Jason Gerecke wrote: >> I made the mistake of setting this to zero and then bringing my >> pen into proximity. Ooops. X crashed. Looks like mathematics >> still can't handle getting the average of zero things ;) >> >> Signed-off-by: Jason Gerecke <killert...@gmail.com> >> --- >> src/wcmXCommand.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c >> index 4207dbe..e589e37 100644 >> --- a/src/wcmXCommand.c >> +++ b/src/wcmXCommand.c >> @@ -620,7 +620,7 @@ int wcmSetProperty(DeviceIntPtr dev, Atom property, >> XIPropertyValuePtr prop, >> if ((values[0] < 0) || (values[0] > 100)) >> return BadValue; >> >> - if ((values[1] < 0) || (values[1] > XWACOM_MAX_SAMPLES)) >> + if ((values[1] < 1) || (values[1] > XWACOM_MAX_SAMPLES)) >> return BadValue; >> >> if (!checkonly) >> -- >> 1.7.1 > > doesn't this need the same check in wcmParseOptions?
Yes, the whole if() should be added to new RawSample (patch 3 of 4). > > also, out of interest - what does RawSample actually do? there's nothing in > the man page. Perhaps we can rename the option while we are here? Its value is the window size on sliding window average done on incoming raw samples with default of 4. SampleWindow or SampleCount may be better names. If someone makes a man page patch, its probably worth noting that ISDv4 do not currently do averaging. I had a patch that enables that but needs testing by someone with said device. I'm a little confused why ISDv4 people are not complaining about non-smooth drawing. Chris ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
