On Sun, Mar 27, 2011 at 10:25 PM, Peter Hutterer
<peter.hutte...@who-t.net> wrote:
> On Thu, Mar 24, 2011 at 06:02:54PM -0700, Jason Gerecke wrote:
>> When a set of arguments cannot be parsed, knowing the word that
>> did not make sense doesn't help if you've used it more than once.
>>
>> Signed-off-by: Jason Gerecke <killert...@gmail.com>
>> ---
>>  tools/xsetwacom.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
>> index 80766d1..fea79d0 100644
>> --- a/tools/xsetwacom.c
>> +++ b/tools/xsetwacom.c
>> @@ -1194,7 +1194,7 @@ static void special_map_property(Display *dpy, XDevice 
>> *dev, Atom btnact_prop, i
>>
>>               if (!keyword_found)
>>               {
>> -                     fprintf(stderr, "Cannot parse keyword '%s'\n", 
>> words[i]);
>> +                     fprintf(stderr, "Cannot parse keyword '%s' at position 
>> %d\n", words[i], i+1);
>
>
> not that it really matters, but is there any way a keyword can succeed once
> and then fail at the second position?
>
> Cheers,
>  Peter
>
>>                       return;
>>               }
>>       }
>> --
>> 1.7.4.1
>>
>>
>> ------------------------------------------------------------------------------
>> Enable your software for Intel(R) Active Management Technology to meet the
>> growing manageability and security demands of your customers. Businesses
>> are taking advantage of Intel(R) vPro (TM) technology - will your software
>> be a part of the solution? Download the Intel(R) Manageability Checker
>> today! http://p.sf.net/sfu/intel-dev2devmar
>> _______________________________________________
>> Linuxwacom-devel mailing list
>> Linuxwacom-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>>
>

I wrote this patch while intentionally trying to break things, so it
may not actually be needed. Its pretty easy to come up with cases
(define 'key' actions, 'button' actions, and then forget to specify
'key' before giving more key actions), though they're pretty
pathological.

Jason

---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.

------------------------------------------------------------------------------
Create and publish websites with WebMatrix
Use the most popular FREE web apps or write code yourself; 
WebMatrix provides all the features you need to develop and publish 
your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to