On Thu, Mar 31, 2011 at 10:57 PM, Peter Hutterer <peter.hutte...@who-t.net>wrote:
> On Thu, Mar 31, 2011 at 10:37:54PM -0700, Ping Cheng wrote: > > On Thu, Mar 31, 2011 at 4:43 PM, Peter Hutterer < > peter.hutte...@who-t.net>wrote: > > > > > /* FIXME: why strstr and not strcmp? */ > > > if (!strstr(device->drv->driverName, "wacom")) > > > continue; > > > > > > > I guess, the intention was to allow driverName has extra characters > instead > > of exact "wacom". As long as it has "wacom" in it, we take care of it. > Not > > sure if it is necessary though. > > I'd rather be precise on the match. I don't think anyone has a driver that > could possibly conflict but substring matches have a nasty habit of finding > things humans don't necessarily see. > > > > would it make sense to have them share the common struct once we've > linked > > > them? > > > > > > > It makes sense. One issue, even with the current code, is how to tell the > > difference between two identical tablets in the driver. How do we know if > we > > are linking the proper devices together? > > > > So far, I assume all devices attached to the same system have different > > product IDs. > > maybe we need an Option Uniq then to let the user associate the devices? > What information can the user use for Uniq to associate the devices, which we do not have in the driver? Both devices have the same product ID and name. Ping
------------------------------------------------------------------------------ Create and publish websites with WebMatrix Use the most popular FREE web apps or write code yourself; WebMatrix provides all the features you need to develop and publish your website. http://p.sf.net/sfu/ms-webmatrix-sf
_______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
