On Mon, Apr 4, 2011 at 6:50 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Apr 04, 2011 at 10:15:16AM -0700, Jason Gerecke wrote: >> On Sun, Apr 3, 2011 at 8:26 PM, Peter Hutterer <peter.hutte...@who-t.net> >> wrote: >> > On Fri, Apr 01, 2011 at 11:17:15AM -0700, Jason Gerecke wrote: > > [cutting some context. why? because I can!] > >> >> The latter is changed by wcmUpdateButtonKeyActions >> >> (after a long call chain beginning with wcmSetProperty) whenever X >> >> detects a change in the WACOM_PROP_STRIPBUTTONS property. >> >> getWheelButton then returns both of these to sendWheelStripEvents. If >> >> a "key" is defined, it will preferentially decode it and send the >> >> necessary events. Otherwise, it interprets the raw integer fakeButton >> >> as the X button to send a button press event for. >> >> >> >> When xsetwacom is given arguments to StripLeftUp, it converts them >> >> into an action and modifies the appropriate offset into >> >> WACOM_PROP_STRIPBUTTONS. When the appropriate motion is made the >> >> driver notices an action is sent and sends it. When it is run without >> >> arguments, it clears the offset, so the same motion results in the >> >> driver not finding an action and sending the default button. Note that >> >> xsetwacom works the same way for "Button X"! Running with arguments >> >> sets an action the driver will preferentially use; running without >> >> arguments clears the action, forcing the driver to fall back on the >> >> raw integer defined in the button[] array. >> > >> > right, so if I understand this correctly, the "default button" it uses then >> > is the (essentially hardcoded) striplup value. which brings me back to my >> > original question: it doesn't reset to the default value but rather removes >> > the new button mapping. if you could change striplup, removing a button >> > mapping would reset to whatever striplup has as current value (and that may >> > not be the _default_). currently this works, but only because we don't seem >> > to have a way to change it. it's really just the wording that matters to me >> > here, even if it appears to be overly anal :) >> > >> I see now -- yes, you are understanding things correctly. >> >> However, In regards to this and your prior paragraph, I'm not sure I >> see the logic in letting the user change striplup. Why /should/ the >> user be able to modify it? If they don't like the mapping, why not use >> already-extant features like setting an action (i.e. modify >> strip_keys[0])? I've tried thinking of several possible motivations, >> but am coming up blank :( >> >> Also, what did you mean by "in spirit with the other discussion of >> allowing physical mappings"? I'm not sure I understand since the >> button[] array is already physical-button-indexed and the strip_keys[] >> and wheel_keys[] don't really /have/ physical buttons... IIRC only >> keys[] is X11-button-indexed, but that could be changed without too >> much hassle. > > long story short - it doesn't really matter. we're mostly just > arguing about the wording in a commit message and I seem to be doing a > better job at confusing you than explaining myself :) I take it that > the behaviour of the strip can be set with actions now (including "button 5" > or somesuch). so to me, the matter is resolved. > > Cheers, > Peter >
I can be a little dense at times, so that could have been part of the problem :) I'll reword the commit message with v2 of my patchset to make it more accurate. Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. ------------------------------------------------------------------------------ Xperia(TM) PLAY It's a major breakthrough. An authentic gaming smartphone on the nation's most reliable network. And it wants your games. http://p.sf.net/sfu/verizon-sfdev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
