On Thu, Apr 07, 2011 at 05:17:34PM -0700, Ping Cheng wrote:
> On Thu, Apr 7, 2011 at 4:02 PM, Peter Hutterer
> <[email protected]>wrote:
>
> > On Thu, Apr 07, 2011 at 12:25:32PM +0300, Timo Aaltonen wrote:
> > > Signed-off-by: Timo Aaltonen <[email protected]>
> > > Tested-by: Manoj Iyer <[email protected]>
> > > ---
> > > src/wcmUSB.c | 1 +
> > > 1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > v2: fixed the resolution to match other stylus-enabled tablets.
> > >
> > > diff --git a/src/wcmUSB.c b/src/wcmUSB.c
> > > index 81af067..3f8e059 100644
> > > --- a/src/wcmUSB.c
> > > +++ b/src/wcmUSB.c
> > > @@ -269,6 +269,7 @@ static struct
> > > { WACOM_VENDOR_ID, 0x9F, 394, 394, &usbTabletPC }, /*
> > CapPlus 0x9F */
> > > { WACOM_VENDOR_ID, 0xE2, 394, 394, &usbTabletPC }, /*
> > TabletPC 0xE2 */
> >
> > obviously unrelated to this patch, but this number doesn't quite look
> > right.
> > Ping, is this correct?
> >
>
> Those numbers do not matter to E2 and 9F since they are touch only devices.
> We'll get the values from HID descriptor. I mentioned this before.
right. memory, meet goldfish. goldfish, meet... I forgot.
> We can change the numbers to something look normal, such as 10000, or add a
> comment to the code to spell it out.
yes please. I'm sure next time this shows up in a patch context I'll
probably ask again :)
Cheers,
Peter
>
> Ping
>
> > { WACOM_VENDOR_ID, 0xE3, 100000, 100000, &usbTabletPC }, /*
> > TabletPC 0xE3 */
> > > + { WACOM_VENDOR_ID, 0xE6, 100000, 100000, &usbTabletPC }, /*
> > TabletPC 0xE6 */
> > >
> > > /* IDs from Waltop's driver, available
> > http://www.waltop.com.tw/download.asp?lv=0&id=2.
> > > Accessed 8 Apr 2010, driver release date 2009/08/11, fork of
> > linuxwacom 0.8.4.
> > > --
> > > 1.7.4.1
> >
------------------------------------------------------------------------------
Xperia(TM) PLAY
It's a major breakthrough. An authentic gaming
smartphone on the nation's most reliable network.
And it wants your games.
http://p.sf.net/sfu/verizon-sfdev
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
