On Tue, Jul 5, 2011 at 8:11 PM, Julian Squires <[email protected]> wrote: > Hi Chris, > > (sorry, I thought I sent this much earlier.) > > On Sat, Jul 2, 2011 at 2:40 PM, Chris Bagwell <[email protected]> wrote: >> Very cool. I'm sure you'll make a lot of people happy with this. You >> should probably post this snippet of your email onto linuxwacom-user's >> list. That is probably were you'll find audience looking to test. > > Good idea. I'll do that today. > >> Also, I have one comment on your wacom_serial.c. Can you make sure >> your only sending 1 tools worth of data per report_sync() call? It >> probably works as you've done it for protocol 4 devices. > > Right, I suspect there's a flaw in the logic in my code here; I am > explicitly sending proximity out for all tools which are not the tool > in use, every event.
This part is good. We take advantage of event filtering all the time to keep logic simple. >I wanted to minimize state that had to be > tracked. But you're saying that, in the case of a switch from the > stylus to the eraser, I should explicitly send BTN_TOOL_PEN as 0, > input_sync(), and then BTN_TOOL_RUBBER as 1? (instead of within the > same event) Yes. That is what you want to make sure happens. For most part this will happen naturally because you'll pull pen out of proximity while your flipping it so you'll briefly get both out of proximity before the next comes in proximity. Since only protocol 5 devices support 2 tools in proximity at same time, you may only need to worry about buttons. As long as you remove ABS_MISC concept, you do not need to do anything special when sending button presses. If you do send ABS_MISC+BTN_TOOL_FINGER then you need to make sure you don't get a proximity change of BTN_TOOL_PEN/ERASER at same sync window you get proximity change of BTN_TOOL_FINGER. Getting rid of ABS_MISC and not using BTN_TOOL_FINGER is simplest approach for buttons so I'm sure you'll end up going that route. Chris > >> See >> http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Kernel_Input_Event_Overview >> for more information. BTW: This web page hasn't been updated but we support generic tablets in xf86-input-wacom now. They are detected by lack of ABS_MISC event and then expected to send events like that page describes generic event protocol. > > Thanks, I'll take a look. > > Cheers, > > -- > Julian Squires > ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
