On Mon, Aug 01, 2011 at 05:46:43PM -0700, Ping Cheng wrote: > On Mon, Aug 1, 2011 at 4:57 PM, Peter Hutterer > <[email protected]>wrote: > > > Static configuration devices only. > > > > Signed-off-by: Peter Hutterer <[email protected]> > > --- > > src/wcmValidateDevice.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c > > index 2f44717..549dfd4 100644 > > --- a/src/wcmValidateDevice.c > > +++ b/src/wcmValidateDevice.c > > @@ -138,8 +138,10 @@ Bool wcmIsAValidType(InputInfoPtr pInfo, const char* > > type) > > WacomCommonPtr common = priv->common; > > char* dsource = xf86CheckStrOption(pInfo->options, "_source", ""); > > > > - if (!type) > > + if (!type) { > > + xf86Msg(X_ERROR, "%s: No type specified\n", pInfo->name); > > return FALSE; > > + } > > > That's a kernel style. We normally use > > if (foo) > { > }
oops, amended and pushed, thanks. Cheers, Peter > in this driver, don't we? I am fine either way tho. > > Reviewed-by: Ping Cheng <pinglinux@gmail,com> for the series. > > Ping ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
