On Wed, Aug 10, 2011 at 6:18 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Tue, Aug 09, 2011 at 05:31:39PM -0700, Jason Gerecke wrote: >> Replaces the deprecated AC_DBLCLICK constant with a new constant >> which denotes when a button action is supposed to cause the driver >> to "hold" the current pressure value. >> --- >> include/Xwacom.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/Xwacom.h b/include/Xwacom.h >> index 3ca8573..421885c 100644 >> --- a/include/Xwacom.h >> +++ b/include/Xwacom.h >> @@ -58,7 +58,7 @@ >> #define AC_CODE 0x0000ffff /* Mask to isolate button >> number or key code */ >> #define AC_KEY 0x00010000 /* Emit key events */ >> #define AC_MODETOGGLE 0x00020000 /* Toggle absolute/relative >> mode */ >> -#define AC_DBLCLICK 0x00030000 /* DEPRECATED: use two button >> events instead */ >> +#define AC_PRESSUREHOLD 0x00030000 /* Maintain current pressure */ >> #define AC_DISPLAYTOGGLE 0x00040000 /* Toggle among screens */ >> #define AC_BUTTON 0x00080000 /* Emit button events */ >> #define AC_TYPE 0x000f0000 /* The mask to isolate event >> type bits */ > > we should probably extend the AC_TYPE mask sooner than later before we run > out of options. in addition, we could introduce an AC_CUSTOM type and then > use the AC_CODE bytes for the actual command type. e.g. pressure hold would > be (AC_CUSTOM | AC_PRESSUREHOLD).
That's a good idea. That would definitely add a lot more room to grow without really affecting anything. > This is strictly speaking an interface break, not much of a problem for > xsetwacom that ships with the driver but any other potential configuration > utilities. Then again, they should have never set such actions anyway so > we're probably good :) If I were to write an AC_CUSTOM patch, should I worry about moving e.g. AC_MODETOGGLE? I didn't think swapping out AC_DBLCLICK would cause much heartburn, but I'm a bit more wary of moving the others since they're in active use. I think it'd be nice to move them over eventually, but how should we handle the process? Jason --- Day xee-nee-svsh duu-'ushtlh-ts'it; nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it. Huu-chan xuu naa~-gha. ------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
