On Tue, Aug 23, 2011 at 6:48 PM, Peter Hutterer
<peter.hutte...@who-t.net> wrote:
> We've dereferenced it several times already and having the check in there
> confuses static analyzers who don't know that the server allocates this for
> us.
>
> This is a leftover from pre-ABI 12 where the drivers had to allocate pInfo
> themselves.
>
> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
> ---
> src/wcmConfig.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/wcmConfig.c b/src/wcmConfig.c
> index cccf220..22f162a 100644
> --- a/src/wcmConfig.c
> +++ b/src/wcmConfig.c
> @@ -575,7 +575,7 @@ SetupProc_fail:
> if (common && priv)
> common->wcmDevices = priv->next;
>
> - if (pInfo && pInfo->fd != -1)
> + if (pInfo->fd != -1)
> {
> close(pInfo->fd);
> pInfo->fd = -1;
> --
> 1.7.6
>
Acked-by: Jason Gerecke <killert...@gmail.com>
Jason
---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
