Patch came threw good.  One minor item before sending to linux-input.
The kernel description convention for HID patches is to have "HID: "
or "HID: wacom: " at beginning.

Also, they will want the patches to be bisectables (meaning the patch
can compile stand alone at minimum).  So that means you need to merge
patch 1 and 2 since it looks like 1 wont compile by itself.

Chris

On Wed, Nov 2, 2011 at 4:20 PM, Przemo Firszt <[email protected]> wrote:
> It's a second step to add Intuos4 Wireless support to hid-wacom driver.
>
> Signed-off-by: Przemo Firszt <[email protected]>
> ---
>  drivers/hid/hid-wacom.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-wacom.c b/drivers/hid/hid-wacom.c
> index eb84bff..db23223 100644
> --- a/drivers/hid/hid-wacom.c
> +++ b/drivers/hid/hid-wacom.c
> @@ -183,6 +183,7 @@ static int wacom_gr_parse_report(struct hid_device *hdev,
>  {
>        int tool, x, y, rw;
>
> +       tool = 0;
>        /* Get X & Y positions */
>        x = le16_to_cpu(*(__le16 *) &data[2]);
>        y = le16_to_cpu(*(__le16 *) &data[4]);
> @@ -300,7 +301,6 @@ static int wacom_raw_event(struct hid_device *hdev, 
> struct hid_report *report,
>        if (!(hdev->claimed & HID_CLAIMED_INPUT))
>                return 0;
>
> -       tool = 0;
>        hidinput = list_entry(hdev->inputs.next, struct hid_input, list);
>        input = hidinput->input;
>
> --
> 1.7.6.4
>
>

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Linuxwacom-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to