On Saturday, January 7, 2012, Chris Bagwell <ch...@cnpbagwell.com> wrote:
> I've already forgotten what your driver patch looks like... but this
> shouldn't technically be needed, right? If the TPC's are still not
> advertising BTN_TOOL_FINGER then there is code to auto add WCM_TPC in
> wcmUSB.c
I need to check how WCM_TPC was set in wcmUSB.c again. Maybe the line in
ValidateDevice is unnecessary any more.
The change in wcmUSB.c was to support older kernels that do not report
resolution. But, since this device is only supported on kernels 2.6.36 or
later here, I guess we do not need that change anymore.
It's been a while since I worked on the device for a customer. The original
kernel was 2.6.35...
I'll test this patch a bit more to see if the change is necessary or not.
Thank you for your comments.
Ping
> Anyways, its not like it hurts anything:
>
> Reviewed-by: Chris Bagwell <ch...@cnpbagwell.com>
>
> On Fri, Jan 6, 2012 at 7:57 PM, Ping Cheng <pingli...@gmail.com> wrote:
>> Signed-off-by: Ping Cheng <pi...@wacom.com>
>> ---
>> src/wcmUSB.c | 3 ++-
>> src/wcmValidateDevice.c | 3 ++-
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
>> index 8451c25..ba88696 100644
>> --- a/src/wcmUSB.c
>> +++ b/src/wcmUSB.c
>> @@ -1,6 +1,6 @@
>> /*
>> * Copyright 1995-2002 by Frederic Lepied, France. <lep...@xfree86.org>
>> - * Copyright 2002-2010 by Ping Cheng, Wacom. <pi...@wacom.com>
>> + * Copyright 2002-2012 by Ping Cheng, Wacom. <pi...@wacom.com>
>> *
>> * This program is free software; you can redistribute it and/or
>> * modify it under the terms of the GNU General Public License
>> @@ -273,6 +273,7 @@ static struct
>> { WACOM_VENDOR_ID, 0x9F, 100000, 100000, &usbTabletPC }, /*
CapPlus 0x9F */
>> { WACOM_VENDOR_ID, 0xE2, 100000, 100000, &usbTabletPC }, /*
TabletPC 0xE2 */
>> { WACOM_VENDOR_ID, 0xE3, 100000, 100000, &usbTabletPC }, /*
TabletPC 0xE3 */
>> + { WACOM_VENDOR_ID, 0xE5, 100000, 100000, &usbTabletPC }, /*
TabletPC 0xE5 */
>> { WACOM_VENDOR_ID, 0xE6, 100000, 100000, &usbTabletPC }, /*
TabletPC 0xE6 */
>>
>> /* IDs from Waltop's driver, available
http://www.waltop.com.tw/download.asp?lv=0&id=2.
>> diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c
>> index 862e005..0e0e57a 100644
>> --- a/src/wcmValidateDevice.c
>> +++ b/src/wcmValidateDevice.c
>> @@ -1,5 +1,5 @@
>> /*
>> - * Copyright 2009 - 2010 by Ping Cheng, Wacom. <pi...@wacom.com>
>> + * Copyright 2009 - 2012 by Ping Cheng, Wacom. <pi...@wacom.com>
>> *
>> * This program is free software; you can redistribute it and/or
>> * modify it under the terms of the GNU General Public License
>> @@ -263,6 +263,7 @@ int wcmDeviceTypeKeys(InputInfoPtr pInfo)
>>
>> case 0xE2: /* TPC with 2FGT */
>> case 0xE3: /* TPC with 2FGT */
>> + case 0xE5: /* TPC with 10FGT*/
>> case 0xE6: /* TPC with 2FGT */
>> TabletSetFeature(priv->common, WCM_TPC);
>> break;
>> --
>> 1.7.6.4
>>
>>
>>
------------------------------------------------------------------------------
>> Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
>> infrastructure or vast IT resources to deliver seamless, secure access to
>> virtual desktops. With this all-in-one solution, easily deploy virtual
>> desktops for less than the cost of PCs and save 60% on VDI infrastructure
>> costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
>> _______________________________________________
>> Linuxwacom-devel mailing list
>> Linuxwacom-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual
desktops for less than the cost of PCs and save 60% on VDI infrastructure
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
