On Wed, Feb 29, 2012 at 06:11:43PM -0800, Jason Gerecke wrote:
> On Wed, Feb 29, 2012 at 4:37 PM, Peter Hutterer
> <peter.hutte...@who-t.net> wrote:
> > xsetwacom.c: In function ‘set_output’:
> > xsetwacom.c:2359:6: warning: variable ‘success’ set but not used
> > [-Wunused-but-set-variable]
> >
> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
> > ---
> > tools/xsetwacom.c | 11 +++++------
> > 1 files changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
> > index 0c24f2c..2c546b1 100644
> > --- a/tools/xsetwacom.c
> > +++ b/tools/xsetwacom.c
> > @@ -2356,7 +2356,6 @@ static void set_output(Display *dpy, XDevice *dev,
> > param_t *param, int argc, cha
> > int x, y;
> > unsigned int width, height;
> > int flags = XParseGeometry(argv[0], &x, &y, &width, &height);
> > - Bool success = False;
> >
> > if (argc != param->arg_count)
> > {
> > @@ -2366,15 +2365,15 @@ static void set_output(Display *dpy, XDevice *dev,
> > param_t *param, int argc, cha
> > }
> >
> > if (MaskIsSet(flags, XValue|YValue|WidthValue|HeightValue))
> > - success = set_output_area(dpy, dev, x, y, width, height);
> > + set_output_area(dpy, dev, x, y, width, height);
> > else if (strcasecmp(argv[0], "next") == 0)
> > - success = set_output_next(dpy, dev);
> > + set_output_next(dpy, dev);
> > else if (strcasecmp(argv[0], "desktop") == 0)
> > - success = set_output_desktop(dpy, dev);
> > + set_output_desktop(dpy, dev);
> > else if (!need_xinerama(dpy))
> > - success = set_output_xrandr(dpy, dev, argv[0]);
> > + set_output_xrandr(dpy, dev, argv[0]);
> > else if (convert_value_from_user(param, argv[0], &head_no))
> > - success = set_output_xinerama(dpy, dev, head_no);
> > + set_output_xinerama(dpy, dev, head_no);
> > else
> > fprintf(stderr, "Unable to find an output '%s'.\n", argv[0]);
> > }
> > --
> > 1.7.7.6
> >
> >
>
> Whoops. Looks like I forgot to remove that in the final version of the
> patch. Thank goodness for compiler warnings :)
>
> For the whole set:
> Reviewed-by: Jason Gerecke <killert...@gmail.com>
thanks. pushed, can be pulled from
git://people.freedesktop.org/~whot/xf86-input-wacom.git :master
Cheers,
Peter
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
