On 27/04/12 19:45 , Bastien Nocera wrote:
> On Fri, 2012-04-27 at 12:50 +1000, Peter Hutterer wrote:
>> Signed-off-by: Peter Hutterer<peter.hutte...@who-t.net>
>> ---
>>   tools/Makefile.am |    4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/Makefile.am b/tools/Makefile.am
>> index b8b0aef..dc1d272 100644
>> --- a/tools/Makefile.am
>> +++ b/tools/Makefile.am
>> @@ -1,4 +1,6 @@
>> -INCLUDES=-I$(top_srcdir)/libwacom -DTOPSRCDIR="\"$(top_srcdir)\""
>> +INCLUDES=-I$(top_srcdir)/libwacom
>> +
>> +AM_CPPFLAGS = -DTOPSRCDIR="\"$(top_srcdir)\""
>
> You're not supposed to override the AM_* variables, they're not yours to
> play with.

Not quite. From 
http://www.gnu.org/software/automake/manual/html_node/Program-Variables.html

AM_CPPFLAGS
     The contents of this variable are passed to every compilation that 
invokes the C preprocessor; it is a list of arguments to the 
preprocessor. For instance, -I and -D options should be listed here.

[...]

INCLUDES
     This does the same job as AM_CPPFLAGS (or any per-target _CPPFLAGS 
variable if it is used). It is an older name for the same functionality. 
This variable is deprecated; we suggest using AM_CPPFLAGS and per-target 
_CPPFLAGS instead.


so it looks like the include paths should be moved to the cppflags as well.

Cheers,
   Peter

>
>>   noinst_PROGRAMS = generate-udev-rules list-devices
>>   generate_udev_rules_SOURCES = generate-udev-rules.c
>
>


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to