On Fri, May 25, 2012 at 2:49 PM, Jason Gerecke <[email protected]> wrote: > ../src/xf86Wacom.c: In function 'wcmEventAutoDevProbe': > ../src/xf86Wacom.c:527:5: warning: return discards 'const' qualifier from > pointer target type [enabled by default]
I'm thinking you copied the wrong warning here? In other patches, I do not know 100% that ""->NULL is OK but seems reasonable. For all in series: Reviewed-by: Chris Bagwell <[email protected]> > > Signed-off-by: Jason Gerecke <[email protected]> > --- > src/wcmCommon.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/wcmCommon.c b/src/wcmCommon.c > index 7199105..edbcd68 100644 > --- a/src/wcmCommon.c > +++ b/src/wcmCommon.c > @@ -330,9 +330,9 @@ static int getScrollDelta(int current, int old, int wrap, > int flags) > > if (flags & AXIS_BITWISE) > { > - current = (int)log2((current << 1) | 0x01); > - old = (int)log2((old << 1) | 0x01); > - wrap = (int)log2((wrap << 1) | 0x01); > + current = log2((current << 1) | 0x01); > + old = log2((old << 1) | 0x01); > + wrap = log2((wrap << 1) | 0x01); > } > > delta = current - old; > -- > 1.7.10.2 > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Linuxwacom-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
