On Fri, May 25, 2012 at 10:30:27AM -0700, Jason Gerecke wrote:
> Commit 477a261e does not handle the case where relative wheel events
> come from a pad device. The Graphire4 produces such events, with the
> result that scrolling with one has been broken ever since.
> 
> Signed-off-by: Jason Gerecke <killert...@gmail.com>

Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>

Cheers,
  Peter

> ---
>  src/wcmCommon.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/wcmCommon.c b/src/wcmCommon.c
> index 7199105..09e5ccd 100644
> --- a/src/wcmCommon.c
> +++ b/src/wcmCommon.c
> @@ -449,7 +449,7 @@ static void sendWheelStripEvents(InputInfoPtr pInfo, 
> const WacomDeviceState* ds,
>  
>       /* emulate events for relative wheel */
>       delta = getScrollDelta(ds->relwheel, 0, 0, 0);
> -     if (delta && IsCursor(priv) && priv->oldProximity == ds->proximity)
> +     if (delta && (IsCursor(priv) || IsPad(priv)) && priv->oldProximity == 
> ds->proximity)
>       {
>               DBG(10, priv, "Relative wheel scroll delta = %d\n", delta);
>               fakeButton = getWheelButton(delta, priv->relup, priv->reldn,
> -- 
> 1.7.10.2
> 
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> 

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to