On Wed, Jun 6, 2012 at 8:53 AM, Bastien Nocera <had...@hadess.net> wrote: > On Tue, 2012-05-29 at 17:09 -0700, Ping Cheng wrote: >> On Wed, May 23, 2012 at 7:17 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > These two button options specify which button controls which LED bank >> > exposed by the kernel. >> > >> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> >> > --- >> > Notably on the Cintiq, the layout of the banks is inverse to what one >> > expects (0 is right, 1 is left). That can be fixed in the kernel but >> > long-term it's better to rely on a specific flag to tell us. >> >> We may not want to fix it in the kernel. People should not assume 0 is >> for left. All Cintiqs have 0 for right, so far ;). You may mention >> Intuos4. But I4 only has one set of LEDs. >> >> > Not sure about the 24HD here - three buttons that control the leds? is this >> > correct? >> >> Every LED has its own button. > > I would really rather have this fixed in the kernel. We already know > which devices have LEDs, and how many, having them correctly numbered > (or at least in a way that makes sense) in there is what we should do.
Well, kernel driver has already reported them. We just need to map those BTN_s to UI properly. linux-input does not distinguish buttons with LEDs from without LEDs. Button events are reported independently from LED changes in kernel. This is true for all LED enabled tablets, no matter LEDs are around a button (I4, I5, and C21UX2), or are embedded in buttons (C24HD). My suggestion to link button and LED together in xf86-input-wacom was rejected last year. That pushed LED control outside of drivers. The benefit for clients is they get the freedom to control LEDs the way they like. However, practically, I think we should provide a set of features in UI that offer users default options to link button(s) to its relevant LEDs even though, in theory, they are independent. Ping ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
