Good eye, but it looks like this bug was already caught and fixed for
the 0.14 release.
The best place to send patches for this driver is
linuxwacom-devel@lists.sourceforge.net. Peter, I, or the other
maintainers will do in a pinch, but you run the risk of us being on
vacation. :)
Jason
---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.
On Thu, Jul 26, 2012 at 6:12 AM, Daniel Martin
<daniel.mar...@secunet.com> wrote:
> Hi Peter and Jason,
>
> while compiling xf86-input-wacom I stumbled across an error.
>
> Should I've mailed this one on xorg-devel? I was not sure so I didn't.
>
> greetings,
> Daniel Martin
>
> ---8<---
>
> Initializing an array of 4 uint32_t and asign a fifth value can't be
> good.
> ---
> src/wcmXCommand.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
> index 57b3f20..c22ae62 100644
> --- a/src/wcmXCommand.c
> +++ b/src/wcmXCommand.c
> @@ -870,18 +870,19 @@ int wcmGetProperty (DeviceIntPtr dev, Atom property)
>
> if (property == prop_serials)
> {
> - uint32_t values[4];
> -
> - values[0] = common->tablet_id;
> - values[1] = priv->old_serial;
> - values[2] = priv->old_device_id;
> - values[3] = priv->cur_serial;
> - values[4] = priv->cur_device_id;
> + uint32_t values[] = {
> + common->tablet_id,
> + priv->old_serial,
> + priv->old_device_id,
> + priv->cur_serial,
> + priv->cur_device_id
> + };
>
> DBG(10, priv, "Update to serial: %d\n", priv->old_serial);
>
> return XIChangeDeviceProperty(dev, property, XA_INTEGER, 32,
> - PropModeReplace, 5,
> + PropModeReplace,
> + sizeof(values)/sizeof(uint32_t),
> values, FALSE);
> }
>
> --
> 1.7.2.5
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
