On Mon, Aug 13, 2012 at 06:05:07PM -0700, Jason Gerecke wrote: > Properties for individual buttons are now named after their > corresponding A-Z identifier in libwacom. For instance, to > change the assignment for button 'D', you would change the > action on the "Wacom button D action" property. > > Note: once apps start to to expect the ability to extract the > physical button from property name, we are stuck with whatever > naming scheme is in use. > > Signed-off-by: Jason Gerecke <killert...@gmail.com> > --- > There are merits to both the "0-n" and "A-Z" notations for > physical button numbers. For instance, the former doesn't > have an issue with more than 26 buttons (...you never know > what crazy hardware may come down the pipe...), but the > latter is more natural for users of libwacom. > > I figure its worth putting this patch out for RFC to see if > there are any feelings for or against a particular naming > scheme.
libwacom is the main user of this atm, I think, so using a naming scheme that helps libwacom is beneficial. As for the limit to 26 buttons - we'll burn that bridge when we get to it. Having said that, using character-based naming scheme means we cannot allow holes in the button sequences, otherwise we'll run out too quickly. Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > > src/wcmXCommand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c > index c3a2a7c..cd01667 100644 > --- a/src/wcmXCommand.c > +++ b/src/wcmXCommand.c > @@ -124,7 +124,7 @@ static void wcmResetButtonAction(InputInfoPtr pInfo, int > button, int nbuttons) > int x11_button = priv->button_default[button]; > char name[64]; > > - sprintf(name, "Wacom button action %d", button); > + sprintf(name, "Wacom button %c action", 'A' + button); > new_action[0] = AC_BUTTON | AC_KEYBTNPRESS | x11_button; > wcmResetAction(pInfo, name, button, priv->btn_actions, priv->keys, > &new_action, prop_btnactions, nbuttons); > } > -- > 1.7.11.4 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
