Hi Jason,
Jason Gerecke said the following on 10/02/2012 06:43 PM:
> [...]
> NAK. I agree this should go in libwacom instead of GNOME, but am not
> at all sold on the "ModeswitchLED" definition. From a database
> normalization standpoint it winds up duplicating data, and could be
> *significantly* more flexible if written a little differently.
>
> We already know which buttons are mode switches thanks to
> "Touchstrip", "Touchstrip2", "Ring", and "Ring2". Specifying the mode
> switch buttons which control LEDs duplicates data and increases the
> chance of internal inconsistency. It'd be better IMHO to have
> "ModeswitchLED" list the mode-switched hardware. (e.g.
> ModeswtichLED=Touchstrip2;Touchstrip).
>
> It'd take a bit more work to implement, but would not only prevent
> internal inconsistency problems, it would also remove the need for my
> heuristic in libwacom_get_modeswitch_led_group. If you're interested
> in finding the LED group associated with a particular piece of
> hardware, simply return its index in ModeswitchLED.
>
> Of course, there's no reason to limit this to mode switches. Perhaps
> in the future we release a tablet with non-modeswitch LEDs that we can
> light up. For instance, a new notification light is available at
> status_led0_select, with status_led{1,2}_select controlling the
> touchring LEDs. We'd want something more like
> "StatusLED=Notification;Ring2;Ring" to capture this. Userspace (e.g.
> GNOME) would know how to drive each kind of status LED it cares about,
> and can safely ignore anything it doesn't understand.
I like that idea a lot, and it doesn't take that more work to
implement either, I'm about to send new patchset implementing the above.
Cheers,
Olivier.
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
