On Mon, Oct 15, 2012 at 8:20 PM, Peter Hutterer <peter.hutte...@who-t.net> wrote: > On Mon, Oct 15, 2012 at 09:02:28PM -0500, Chris Bagwell wrote: >> On Mon, Oct 15, 2012 at 8:34 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >> > We want libwacom to react to changes in Makefile.am's >> > >> > Long writeup: >> > http://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/ >> > >> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> >> >> For what its worth, for projects that do like to enable maintainer >> mode, I prefer they also check in the Makefile.in's because of the >> grief that can occur when git is missing them and configure is >> ignoring that role. Since wacom doesn't check them in, I also prefer >> deleting this line. > > Can you expand on the git issue you point out here? I'm not sure what you > mean. > >> Also, I think projects that distribute an autogen.sh scripts have >> their roots in this setting as well. Its primary feature is a short >> cut to force Makefile regeneration when we've gone out of our way to >> disable that automatice feature. Its an option to either delete that >> script now or remove the configure part. Hopefully, people that muck >> with configure.ac scripts already know you need to run autoreconf >> after modifying it and the Makefile will now have working rules to >> rerun configure after modifying Makefile.am. > > regarding autogen.sh, I'll squash in the commit to remove > --enable-maintainer-mode from that script since it's now useless anyway, but > I'd like to leave the script there for now, if only because of habit.
I didn't get the whole picture of this discussion yet. Just to make sure it is not due to my habit ;-). So, please update the script the way you like. > fwiw, I personally really hate it that one project I'm working on _doesn't_ > call configure from autogen. it's annoying, forcing me to run two commands > where I could only need to run one. Hope linuxwacom is not the project you hate. I am not confident ;(. Please update it so it gets to your "liked" list. Ping ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
