On Tue, Dec 04, 2012 at 01:22:25PM +1000, Peter Hutterer wrote:
> On Wed, Nov 21, 2012 at 12:15:22PM -0800, Ping Cheng wrote:
> > We upscaled the resolutions in WacomModelDesc and for absinfos that
> > support resolution. But we forgot to update them for older kernels
> > that do not support resolution in absinfo.
>
> help my memory - when did we upscale the resolution?
ok, nevermind, I found that bit
> > Signed-off-by: Ping Cheng <pi...@wacom.com>
> > ---
> > src/wcmUSB.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/wcmUSB.c b/src/wcmUSB.c
> > index acce5ee..418ccbc 100644
> > --- a/src/wcmUSB.c
> > +++ b/src/wcmUSB.c
> > @@ -331,7 +331,7 @@ static struct
> > { NTRIG_VENDOR_ID, 0x01, 44173, 36772, &usbTabletPC },
> >
> > /* Add in Lenovo W700 Palmrest digitizer */
> > - { LENOVO_VENDOR_ID, 0x6004, 2540, 2540, &usbTabletPC } /* Pen-only */
> > + { LENOVO_VENDOR_ID, 0x6004, 100000, 100000, &usbTabletPC } /*
> > Pen-only */
this isn't upscaling, this is just using the right units (units/m instead of
units/inch)
ack to the two changes, but they need to be two patches - one to update the
W700, one to update the resolution into the right range. Plus a commit
message that mentions that the source data is hundredths of a mm, I had to
go check the source to understand why we're using 100000 here.
Cheers,
Peter
> > };
> >
> > static Bool usbWcmInit(InputInfoPtr pInfo, char* id, float *version)
> > @@ -572,7 +572,7 @@ int usbWcmGetRanges(InputInfoPtr pInfo)
> > {
> > if (is_touch)
> > common->wcmTouchResolX =
> > - (int)(((double)common->wcmMaxTouchX * 10.0
> > + (int)(((double)common->wcmMaxTouchX * 100000.0
> > / (double)absinfo.maximum) + 0.5);
> > else
> > common->wcmMaxStripX = absinfo.maximum;
> > @@ -661,7 +661,7 @@ int usbWcmGetRanges(InputInfoPtr pInfo)
> > {
> > if (is_touch)
> > common->wcmTouchResolY =
> > - (int)(((double)common->wcmMaxTouchY * 10.0
> > + (int)(((double)common->wcmMaxTouchY * 100000.0
> > / (double)absinfo.maximum) + 0.5);
> > else
> > common->wcmMaxStripY = absinfo.maximum;
> > --
> > 1.7.10.4
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
