On Wed, Dec 12, 2012 at 9:49 AM, Jason Gerecke <killert...@gmail.com> wrote:
> On Thu, Dec 6, 2012 at 4:21 PM, Ping Cheng <pingli...@gmail.com> wrote:
>
>> While adding support to true MT in the driver, generic PAD support
>> was broken. The generic way of reporting PAD events in the kernel
>> is a big pain in the xxx. It has caused more trouble than it's
>> worth. The community wanted it this way. But, they do not need to
>> support it and they do not use the devices either.
>>
>> Enough ranting. Let's get the job done. One more patch to follow.
>>
>> Signed-off-by: Ping Cheng <pi...@wacom.com>
>> ---
>> src/wcmUSB.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
>> index 4b5f53b..5e5e4e2 100644
>> --- a/src/wcmUSB.c
>> +++ b/src/wcmUSB.c
>> @@ -1651,6 +1651,12 @@ static void usbDispatchEvents(InputInfoPtr pInfo)
>> else if (event->type == EV_KEY)
>> {
>> usbParseKeyEvent(common, event, channel);
>> +
>> + /* for generic device, usbParseBTNEvent is only
>> valid for
>> + * PAD device. Make sure events are sent on the
>> right channel.
>> + */
>> + if (common->wcmProtocolLevel ==
>> WCM_PROTOCOL_GENERIC)
>> + private->wcmBTNChannel = PAD_CHANNEL;
>>
>
> Wouldn't usbChooseChannel be a better home for this addition?
>
I guess so. Since I traced the issue here, I focused on this code too much
and was not in a rational mood to think...
Will make a v2 soon.
Ping
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
