Errors when setting an action property should not be swallowed. Note
that because the containing function does not bother to call this
function 'checkonly', clients still can't find out about errors
until its too late. We'll fix this in the next commit.
Signed-off-by: Jason Gerecke <killert...@gmail.com>
---
src/wcmXCommand.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c
index 713836c..80831c3 100644
--- a/src/wcmXCommand.c
+++ b/src/wcmXCommand.c
@@ -556,7 +556,9 @@ static int wcmSetActionsProperty(DeviceIntPtr dev, Atom
property,
}
XIGetDeviceProperty(dev, subproperty, &subprop);
- wcmSetActionProperty(dev, subproperty, subprop,
checkonly, &handlers[index], &actions[index]);
+ rc = wcmSetActionProperty(dev, subproperty, subprop,
checkonly, &handlers[index], &actions[index]);
+ if (rc != Success)
+ return rc;
}
}
--
1.8.1.1
------------------------------------------------------------------------------
Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
much more. Get web development skills now with LearnDevNow -
350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
SALE $99.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122812
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
