On Wed, 2013-05-29 at 12:31 -0700, Jason Gerecke wrote: > Looks sensible enough. Just move the hunk that modifies the comment into > patch 1/3.
For reference Ping Cheng did an update of my patches which he will hopefully push in the repository pretty soon. Thanks for your review! :) > Otherwise: > > Acked-by: Jason Gerecke <killert...@gmail.com> > > > Jason > --- > Now instead of four in the eights place / > you’ve got three, ‘Cause you added one / > (That is to say, eight) to the two, / > But you can’t take seven from three, / > So you look at the sixty-fours.... > > > > On Fri, May 24, 2013 at 4:06 PM, Sjoerd Simons <sjo...@luon.net> wrote: > > > Transform touch coordinates in the same way as other events coming from > > the wacom driver otherwise setting for exmaple the Wacom Rotation > > property has no effect > > > > Signed-off-by: Sjoerd Simons <sjo...@greynoise.nl> > > --- > > src/wcmTouchFilter.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/src/wcmTouchFilter.c b/src/wcmTouchFilter.c > > index 1720a76..7850724 100644 > > --- a/src/wcmTouchFilter.c > > +++ b/src/wcmTouchFilter.c > > @@ -112,6 +112,8 @@ wcmSendTouchEvent(WacomDevicePtr priv, WacomChannelPtr > > channel) > > WacomDeviceState oldstate = channel->valid.states[1]; > > int type = -1; > > > > + wcmRotateAndScaleCoordinates (priv->pInfo, &state.x, &state.y); > > + > > valuator_mask_set(mask, 0, state.x); > > valuator_mask_set(mask, 1, state.y); > > > > @@ -139,7 +141,7 @@ wcmSendTouchEvent(WacomDevicePtr priv, WacomChannelPtr > > channel) > > * generated. > > * > > * @param[in] priv > > - * @param[in] contact_id ID of the contact to send event for (at minimum) > > + * @param[in] contact_id ID of the contact to send event for > > */ > > static void > > wcmFingerMultitouch(WacomDevicePtr priv, int contact_id) { > > -- > > 1.7.10.4 > > > > > > > > ------------------------------------------------------------------------------ > > Try New Relic Now & We'll Send You this Cool Shirt > > New Relic is the only SaaS-based application performance monitoring service > > that delivers powerful full stack analytics. Optimize and monitor your > > browser, app, & servers with just a few lines of code. Try New Relic > > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > > _______________________________________________ > > Linuxwacom-devel mailing list > > Linuxwacom-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel > > ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel