On Fri, 2013-05-31 at 16:44 +1000, Peter Hutterer wrote:
> On Fri, May 24, 2013 at 10:47:32PM +0200, Sjoerd Simons wrote:
> > Attached is an updated version of the patch which prevents
> > false-positives by checking whether a touchscreen device uses the wacom
> > kernel driver (by checking the ID_USB_DRIVER property from udev)
>
> Please see my reply to Ritesh in this thread:
> http://old.nabble.com/Re%3A-libwacom-not-recognizing-touch%28screen%29-devices-p35313125.html
>
> we have a device database of the devices we support - might as well use it
> :)
Read that now (didn't see it before, i suck at searching the SF mail
archives it seems), not sure if it makes much sense to me...
libwacom_new_from_path seems to roughly speaking work in two steps:
1: Get raw device information
2: lookup device in the database, and if found (or if WFALLBACK_GENERIC
is given) create the WacomDevice struct.
What you seem to be suggesting is to fail getting the raw device
information, in case the device is (practically speaking) a touchscreen
that's not in the the database.. Which makes the semantics of
WFALLBACK_GENERIC depend on the device type, which seems a bit odd.
But if that's what you would like to see (Only do the WFALLBACK_GENERIC
fallback for touchpads and non-integrated tablets), i'm happy to provide
a patch that does that explicitly which seems nicer then having
get_device_info pre-check the database :)
Btw, checking whether the wacom driver is used instead of the database
has the advantage something like g-s-d which uses WFALLBACK_GENERIC
still works when one has a recent kernel which recognizes a new device
but an older libwacom database.
--
Sjoerd Simons <sjo...@luon.net>
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
