On Sun, Sep 15, 2013 at 11:48 PM, Peter Hutterer
<peter.hutte...@who-t.net>wrote:

> On Fri, Sep 13, 2013 at 11:02:02AM -0700, Jason Gerecke wrote:
> > On Thu, Sep 12, 2013 at 4:20 PM, Peter Hutterer
> > <peter.hutte...@who-t.net> wrote:
> > > On Wed, Sep 11, 2013 at 06:01:49PM -0700, Ping Cheng wrote:
> > >> New Cintiq/Intuos Pro Pen looks very close to the existing Classic
> > >> Pen. Use the Classic image so we do not have to create a new one
> > >> for Pro Pen since the person who planned to add an image for Pro
> > >> Pen does not have time to work on this project any more.
> > >
> > > if it's just the image, wouldn't it be easier to duplicate the image
> and fix
> > > it at a future point but leave the database entry correct?
> > > or am I missing something here?
> > >
> > > Cheers,
> > >    Peter
> > >
> >
> > If it was our own sandbox we'd be playing in, sure :) I'm not sure
> > GNOME would accept a patch that just duplicated an image, and neither
> > Ping nor I have the time to make a proper graphic.
> >
> > Actually, in hindsight, I don't much like the "Type=Pro" designation.
> > We have pens spanning from the original Intuos through the Intuos 4
> > which area all categorized as one of Classic, General, Inking, Marker,
> > or Airbrush. What is so special about this pen that requires a brand
> > new type designation? The industrial design? By that logic, we'd have
> > a dozen or more types... If we want g-c-c to have silhouettes that
> > match the industrual design, we should probably have it make use of
> > the pen ID instead.
> >
> > What is the type field for? What do its values *mean*? I'd rather not
> > push any patches until we know what the right way forward is.
>
> quick check of gnome-control-center shows that the stylus type translates
> into an icon name, which is a svg graphic. and that is displayed in the
> control-center.
>
> so yeah, if the Pro series is just one more in the line of the usual, then
> Ping's patch is certainly right. if the Pro is a new type of pen that's
> significantly different (like Clasic vs Airbrush), then we should have a
> new
> type for it.
>

It is a normal Intuos pen with a new name and a different "look and feel".
No functionality changes involved...

Thank you both for your feedback.

Ping


> Cheers,
>    Peter
>
> >
> > Jason
> > ---
> > Now instead of four in the eights place /
> > you’ve got three, ‘Cause you added one  /
> > (That is to say, eight) to the two,     /
> > But you can’t take seven from three,    /
> > So you look at the sixty-fours....
> >
> > >
> > >>
> > >> Signed-off-by: Ping Cheng <pi...@wacom.com>
> > >> ---
> > >>  data/libwacom.stylus | 4 ++--
> > >>  1 file changed, 2 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/data/libwacom.stylus b/data/libwacom.stylus
> > >> index a4fa8ba..290fe5e 100644
> > >> --- a/data/libwacom.stylus
> > >> +++ b/data/libwacom.stylus
> > >> @@ -134,7 +134,7 @@ Type=Classic
> > >>  Name=Pro Pen
> > >>  HasEraser=true
> > >>  Buttons=2
> > >> -Type=Pro
> > >> +Type=Classic
> > >>
> > >>  [0x180802]
> > >>  # DTH2242 Pen
> > >> @@ -247,7 +247,7 @@ Type=General
> > >>  # Cintiq 13HD
> > >>  Name=Pro Pen Eraser
> > >>  IsEraser=true
> > >> -Type=Pro
> > >> +Type=Classic
> > >>
> > >>  [0x18080a]
> > >>  # DTH2242 Eraser
> > >> --
> > >> 1.8.1.2
> > >>
> > >
> > >
> ------------------------------------------------------------------------------
> > > How ServiceNow helps IT people transform IT departments:
> > > 1. Consolidate legacy IT systems to a single system of record for IT
> > > 2. Standardize and globalize service processes across IT
> > > 3. Implement zero-touch automation to replace manual, redundant tasks
> > >
> http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
> > > _______________________________________________
> > > Linuxwacom-devel mailing list
> > > Linuxwacom-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>
------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to