On Thu, Oct 3, 2013 at 5:18 PM, Ping Cheng <pingli...@gmail.com> wrote:
> Some devices send expresskeys on its own interface, that is, there
> is no motion/pointer events associated with the pad interface.
>
> This patch handles above case.
>
Again, more context about the underlying problem and the solution
presented would be very helpful.
At first glance the change appears to only affect when a device is
considered a tablet PC, and doesn't appear to have anything to do with
the pad device. After much head scratching, I *assume* the problem is
that these axis-less pad devices were being incorrectly caught by this
block of code and having BTN_TOOL_FINGER set. The presence of
BTN_TOOL_FINGER on a generic device like the Bamboo would make the pad
show up as touch instead.
If that was explained in the description, I wouldn't have spent quite
as much time puzzling over the patch.
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
> Signed-off-by: Ping Cheng <pi...@wacom.com>
> ---
> src/wcmUSB.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/wcmUSB.c b/src/wcmUSB.c
> index 634eb1c..4a49c4a 100644
> --- a/src/wcmUSB.c
> +++ b/src/wcmUSB.c
> @@ -1756,7 +1756,8 @@ static void usbGenericTouchscreenQuirks(unsigned long
> *keys,
> */
> if (ISBITSET(keys, BTN_TOUCH) &&
> !ISBITSET(keys, BTN_TOOL_FINGER) &&
> - !ISBITSET(keys, BTN_TOOL_PEN))
> + !ISBITSET(keys, BTN_TOOL_PEN) &&
> + ISBITSET(abs, ABS_X))
> {
> SETBIT(keys, BTN_TOOL_FINGER); /* 1FGT */
> TabletSetFeature(common, WCM_TPC);
> --
> 1.8.1.2
>
>
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
