On Wed, Feb 05, 2014 at 03:40:19PM -0800, Ping Cheng wrote: > On Tue, Feb 4, 2014 at 8:04 PM, Peter Hutterer > <peter.hutte...@who-t.net>wrote: ...
> > device->num_strips = g_key_file_get_integer(keyfile, > > FEATURES_GROUP, "NumStrips", NULL); > > > device->num_buttons = g_key_file_get_integer(keyfile, > > FEATURES_GROUP, "Buttons", &error); > > > if (device->num_buttons == 0 && > > > diff --git a/libwacom/libwacom.c b/libwacom/libwacom.c > > > index 1b9b398..574e6f3 100644 > > > --- a/libwacom/libwacom.c > > > +++ b/libwacom/libwacom.c > > > @@ -730,6 +730,7 @@ libwacom_print_device_description(int fd, const > > WacomDevice *device) > > > dprintf(fd, "Ring=%s\n", libwacom_has_ring(device) ? > > "true" : "false"); > > > dprintf(fd, "Ring2=%s\n", libwacom_has_ring2(device) ? > > "true" : "false"); > > > dprintf(fd, "Touch=%s\n", libwacom_has_touch(device) ? > > "true" : "false"); > > > + dprintf(fd, "TouchSwitch=%s\n", libwacom_has_touchswitch(device)? > > "true" : "false"); > > > > libwacom.c: In function 'libwacom_print_device_description': > > libwacom.c:733:2: warning: implicit declaration of function > > 'libwacom_has_touchswitch' [-Wimplicit-function-declaration] > > dprintf(fd, "TouchSwitch=%s\n", libwacom_has_touchswitch(device)? "true" > > : "false"); > > > > I also noticed that the tests are missing of the new feature, so if we do > > have a bug that doesn't print the device correctly we wouldn't notice. And, > > coincidentally, running test/list-devices shows the tablets above with > > > TouchSwitch=false... > > > > How do I run test/list-devices? libwacom/tools/list-devices, sorry. should be built unconditionally and it uses the git database, so any device that is added should immediately show up. Cheers, Peter ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
