Peter Hutterer writes: > > The full link would be something along the line of: > http://sourceforge.net/apps/mediawiki/linuxwacom/index.php?title=Main_Page > with the obvious change to the wiki page explaining this issue. > > You'll need a wiki account, ping me when you have one so I can give you edit > rights.
I should have an account, I'm currently trying to get the password reset as the one I used to use doesn't seem to be valid any more. > > +#define LIMIT_LOW_PRESSURE 20 /* percentage of max value */ > > extra space here > > > +#define PERCENT_TOLERANCE 10 > > you don't seem to be using this define > Fixed. > > + LogMessageVerbSigSafe( > > + X_WARNING, 0, > > + "%s(%d) has seen an initial pressure > 0\n\t" > > + "there is a base pressure of %d which > > persists\n\t" > > + "while the pen is in proximity and " > > + "which is too close\n\tto the maximum value > > (%d).\n\t" > > + "This indicates a worn out pen, " > > + "Time to change your tool. Also see:\n\t" > > + "http://linuxwacom.sourceforge.net/Pen_Wear.\n";, > > + priv->pInfo->name, priv->serial, > > priv->minPressure, > > + common->wcmMaxZ); > > This is a personal preference but I'd prefer a printf line to go >80 lines > and ends with a \n over a line that wraps and has the \n\t inside. Makes it > easier to grep for and most of us have screens that can handle the odd 80+ > line :) I do need to break in between but I have made the lines much longer and only break after sentences. > > - > > + int oldMinPressure; /* to record the last minPressure before going > > out of proximity */ > > + unsigned int eventCount; /* count number of events while in proximity */ > > bit more alignment of comments would be nice but I suspect the rest of the > file is messed up already, so with the above addressed Yup. Fixed. > > Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Thanks! Cheers, Egbert. ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
