On Sat, Mar 15, 2014 at 2:32 AM, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > > On 03/15/2014 10:27 AM, Hans de Goede wrote: >> >> Hi, >> >> On 03/14/2014 10:52 PM, Jason Gerecke wrote: >>> >>> On Wed, Mar 12, 2014 at 8:12 AM, Hans de Goede <hdego...@redhat.com> >>> wrote: >>>> >>>> This mostly consists of skipping common fd handling when server managed >>>> fds >>>> are in used, the rest is handled by xf86OpenSerial and our wcmClose >>>> xf86CloseSerial wrapper. >>>> >>>> Signed-off-by: Hans de Goede <hdego...@redhat.com> >>>> --- >>> >>> >>> I threw together a small virtual machine with the xserver from git, >>> and noticed that after applying this patch some tools have trouble >>> being spawned. I see the stylus device getting hotplugged, and then >>> sucessfully creating a dependent eraser tool. The dependent cursor and >>> pad tools that follow afterward throw an error while being created. >>> The EVIOCGVERSION ioctl in usbDetect appears to be failing with EBADF. >>> The file descriptor for these tools matches that of the stylus/eraser, >>> so I'm a little confused at why we'd get EBADF at that point in time. >> >> > > Scrap my last mail, I think I know what is causing your problem, for things > to work properly you also need the recent set of Xserver patches I posted > to deal with multiple inputdevs sharing a single fd on the server side, > which > is not yet upstream. Its reviewed and acked now, so I'll send a pull-req > right > away. > > On the mean time try using: > http://cgit.freedesktop.org/~jwrdegoede/xserver > > Regards, > > Hans >
As you suspected, I was seeing problems with getting a duplicate fd from systemd-logind. IIRC, when this happened the server would fallback to the old behavior and leave our driver responsible for the fd (which seemed to be fine for some tools, but not all). Re-building with your git tree instead of the master does seem to have solved the issue though :) Aside from a nit-pick on style (the 'goto' in this patch rubs me the wrong way), the set looks good. Reviewed-by: Jason Gerecke Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
