On Thu, 2014-09-11 at 14:45 -0400, Benjamin Tissoires wrote: > + /* Parse the PRODUCT attribute (for Bluetooth and USB) */ > + retval = get_bus_vid_pid (device, bus, vendor_id, product_id, > error); > + if (retval) > + goto bail;
Can you rename the bail label to out? I don't like it that it's going to "bail" even though there was success :) Other than that, looks good to me. ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
