On Fri, Dec 05, 2014 at 01:39:26PM -0800, Jason Gerecke wrote:
> Fixes a minor error in commit 52fe01c which results in the driver
> invalidating an fd prior to (potentially) closing it. This reversed
> order causes us to leak the fd and can result in eventual exhasution.
> 
> Fixes SF #263
> 
> Signed-off-by: Jason Gerecke <killert...@gmail.com>

Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>

Cheers,
   Peter

> ---
>  src/xf86Wacom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c
> index e6962dd..55b8b7c 100644
> --- a/src/xf86Wacom.c
> +++ b/src/xf86Wacom.c
> @@ -753,9 +753,9 @@ static void wcmDevClose(InputInfoPtr pInfo)
>  
>       if (pInfo->fd >= 0)
>       {
> -             pInfo->fd = -1;
>               if (!--common->fd_refs)
>                       wcmClose(pInfo);
> +             pInfo->fd = -1;
>       }
>  }
>  
> -- 
> 2.1.3
> 
> 
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> 

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to