On 3/11/2015 7:01 PM, Peter Hutterer wrote:
> Found by coverity
>
> Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
> ---
>   test/dbverify.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/test/dbverify.c b/test/dbverify.c
> index 644bd1b..4abe9fa 100644
> --- a/test/dbverify.c
> +++ b/test/dbverify.c
> @@ -170,6 +170,7 @@ compare_written_database(WacomDeviceDatabase *db)
>
>       rmtmpdir(dirname);
>       free(dirname);
> +     free(devices);
>   }
>
>
>

Are similar 'free' statements necessary in the 'compare_databases' 
function as well? It also calls 'libwacom_list_devices_from_database' 
and doesn't seem to free the results afterward.

Aside from that, for this libwacom set:

Reviewed-by: Jason Gerecke <killert...@gmail.com>

-- 
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to