# what system are you on where you don't have udev but you run linuxwacom? It's my own linux distro. I used to run udev, but with devfs and other things now being available, I don't need it and I'm not going the systemd route. People with busybox based mini-linuxes will also possibly not have udev.
> AC_PREREQ([2.60]) > AC_INIT([xf86-input-wacom], > - [0.32.0], > + [0.32.1], # version numbering is done by the maintainer, please drop this hunk. Okay, I didn't know what I should call the new path. Is there a standard for that? > # Initialize Automake > AM_INIT_AUTOMAKE([foreign dist-bzip2 no-dist-gzip]) > -AM_MAINTAINER_MODE([enable]) > +AM_MAINTAINER_MODE([disable]) # this shouldn't be here. If you put MAINTAINER_MODE back on, autoconf/automake goes completely loopy, and it does with the unchanged source code too! But I guess that's not something that's relevant to the patch. # fwiw, if we have a reliable non-udev approach then we don't need to # keep the udev bits around. I'm not so sure of that. I'm surprised the original developer used udev when there's the /sys/dev/char/<major>:<minor> path, especially given that they're happy to open the id file using a sysfs path, this implies they've looked around sysfs. It occurs to me that maybe sysfs hasn't always had the /sys/dev/char/<major>:<minor> paths, thus some systems might still have to use udev. This way we've got complementary systems that people can move between according to circumstance. we don't use // comments, and please make sure indentation and whitespace usage matches the rest of the file. That goes for the whole patch. # your commit message says /sys/dev/char/ but here you use # /sys/dev/major:minor which doesn't exist. Did you test this patch? Yep, I did. It passes 'make check' and it's running on my system and the tablet screen works. However, I'm thinking that this code is in the 'attach' tool, which I didn't run, I must admit I thought it was autorun by the driver. I think you're right that this would break the attach tool, so I'll look into that. # also, sprintf into a PATH_MAX buffer means you don't have the worry about # allocation. I used asprintf because the original developer did and I figured I should follow that. I'll switch it to snprintf Okay, I'll make the changes and resend a patch. I'm a bit new to patches and the like, so it might take a couple of tries. Colum ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
