On Fri, Apr 1, 2016 at 12:35 AM, Aaron Armstrong Skomra <sko...@gmail.com> wrote: > > On Thu, Mar 31, 2016 at 11:45 AM, Benjamin Tissoires > <benjamin.tissoi...@gmail.com> wrote: >> >> On Thu, Mar 31, 2016 at 5:12 PM, Benjamin Tissoires >> <benjamin.tissoi...@redhat.com> wrote: >> > Used gnome-settings-daemon to spot few tweaks required: >> > - the left and right buttons should be inverted or the >> > label is misplaced > > > I'm not sure how the labels are inverted, but both before and after work for > me.
If you look at the text alignment before and after the patch, you'll see that the texts were misaligned: those on the left were aligned to the left, and the rights, were at right. See the difference on the "left touchring mode switch". However, this is a problem after a few tests. When the OSD is not shown, the GNOME list of buttons is now completely busted :( I'd say the solution is to fix g-s-d to rely on the svg alignment tag, or add a new tag in libwacom for that. > >> >> > - the SVG has been squared a bit and aligned properly >> >> > > > > The SVG looks great! Thanks for this, I'm lucky there is no illustration > test to work as a sw engineer at > Wacom. I ended up writing the SVG like code. For those that are curious (or > need svg work done ;) I've > attached screenshots of the before and after layouts. Thanks. I ended up also raising the buttons that were under the others to properly have the leaders on top of the crossed buttons in the v2. > >> >> > Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> >> > --- >> > >> > Hi, >> > >> > while playing with the ExpressKey Remote (well, a recording actually), I >> > noticed >> > that the entry in the DB and the SVG could get some care. >> > >> > I still haven't figured out a way to not override the text g-s-d outputs >> > in the middle of the screen without resorting to cut the labels on the >> > left or >> > the right. >> > >> > Also, the leaders are overlapping too much with the buttons IMO, but I >> > do not >> > see a better way of handling this either. >> > >> > BTW, for those who wants to test this, you need to force g-s-d to show >> > the >> >> > on-screen help as g-c-c won't allow to configure it. I run a simple >> > command > > > Also if anyone feels like building gsd/gcc there are patches for EKR support > at [1]. I'll have a look. > >> >> > that assigned Button P to the onscreen help: >> >> > PATH=$(/usr/libexec/gsd-list-wacom | grep "Generic settings" | grep >> > "056a:0331" | sed 's/.*path: \(.*\))/\1/') >> >> Hmm, this is embarrassing... Do not try this at home, or at least use >> a different variable name :) > > > I am embarrassed to say that I cut and paste your command without thinking > about what it would do. :O Hehe > > This doesn't pass make check for me, The svg tester is unhappy: > > ERROR:tablet-svg-validity.c:117:check_button: assertion failed: (node != > NULL) > FAIL tablet-svg-validity (exit status: 134) OK, thanks. Fixed locally. Cheers, Benjamin > > Best, > Aaron > > [1] https://bugzilla.gnome.org/show_bug.cgi?id=750745 > ------------------------------------------------------------------------------ _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
