On Wed, May 10, 2017 at 11:14 AM, Sebastian Reuße <s...@wirrsal.net> wrote: > > Sebastian Reuße <s...@wirrsal.net> writes: > >> XkbGetMap is more robust in cases where certain keyboard description >> components >> are missing. XkbGetKeyboard will fail when any component cannot be resolved; >> since all XkbAllComponentsMask is requested, any missing component will >> result >> in the call returning NULL. Since we don’t necessarily need all >> components (e.g., keyboard geometry, keymap names), we use XkbGetMap instead. > > Alternatively, one might try whether a less encompassing components mask > will do. XkbGetMap appears to just NULL those components of the struct > which are unavailable, while XkbGetKeyboard will return NULL wholesale. > > Best regards, > > SR > > -- > Insane cobra split the wood > Trader of the lowland breed > Call a jittney, drive away > In the slipstream we will stay >
Thanks for the updated patch :) I'll wait for Peter's response, since XKB is a dark corner of the xserver that I've (thankfully) never had to shine my flashlight too intensely on. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
