On November 3, 2017 2:23:10 PM PDT, Benjamin Tissoires 
<benjamin.tissoi...@gmail.com> wrote:
>On Fri, Nov 3, 2017 at 9:15 PM, Aaron Armstrong Skomra
><sko...@gmail.com> wrote:
>>
>>
>> On Fri, Nov 3, 2017 at 7:19 AM, Benjamin Tissoires
>> <benjamin.tissoi...@gmail.com> wrote:
>>>
>>> The Dell canvas 27 is an external monitor with pen and touch, but
>the
>>> pen is provided by Wacom, and the touch by Advanced Silicon.
>>> To have proper touch arbitration, we need to force xf86-input-wacom
>>> to also handle the touch part.
>>>
>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@gmail.com>
>>> ---
>>>  conf/70-wacom.conf | 9 +++++++++
>>>  1 file changed, 9 insertions(+)
>>>
>>> diff --git a/conf/70-wacom.conf b/conf/70-wacom.conf
>>> index a20e3a3..86a3f90 100644
>>> --- a/conf/70-wacom.conf
>>> +++ b/conf/70-wacom.conf
>>> @@ -101,3 +101,12 @@ Section "InputClass"
>>>         Driver "wacom"
>>>         Option "Button2" "3"
>>>  EndSection
>>> +
>>> +# Dell Canvas 27 (touch part is an Advanced Silicon, pen part a
>Wacom)
>>> +Section "InputClass"
>>> +        Identifier "Dell Canvas 27 Touch"
>>> +        MatchUSBID "2575:0204"
>>> +        MatchDevicePath "/dev/input/event*"
>>> +        MatchIsTouchscreen "true"
>>> +        Driver "wacom"
>>> +EndSection
>>> --
>>

Patch looks sensible enough:

Reviewed-By: Jason Gerecke <jason.gere...@wacom.com>

>>
>>
>> HI Benjamin,
>>
>> I know that the last display device that I added support for required
>> changes to wcmUSB.c and
>> wcmValidateDevice.c [1] for Centos 6.
>
>Oh... I thought the xorg wacom driver was now smart enough to not
>require such changes...
>

The driver can auto detect most of this stuff, but some data is not available 
from the RHEL6 kernel (off the top of my head, the axis resolution and 
touchscreen/touchpad prop). An entry would need to be added for full 
compatibility.

That said, the situation is somewhat moot on RHEL6 since there isn't yet an 
input-wacom or kernel patch to support the pen. Until such a patch comes into 
existence, users can just remove this xorg.conf.d option to have the evdev 
driver control the touchscreen instead.

>>
>> I'm not very familiar with the x driver conf files, so it may be that
>this
>> also accomplishes
>> the same thing by another means.
>
>I'd say it's different. Here my patch just forces the Advanced Silicon
>touchscreen to be handled by xf86-input-wacom so the xorg driver can
>do touch arbitration.
>Your patch tweaks the tablet so that it is usable from the application
>point of view.
>We might need such changes also :/
>
>> If you're just aiming for Centos 7 support,
>> or if you know
>> this conf file also works for Centos 6 this seems fine. Otherwise the
>driver
>> probably needs changes
>> similar to the commit below to support this device. If you'd like me
>to work
>> on that, let me know and I'll
>> see if I can find a device.
>
>I'd be happy if you could have a look at the device itself. Note that
>you need a kernel patch for it to report accurate coordinates [2].
>But one solution could be to teach me what to check and I'll assess
>myself if we need changes in those files too.
>
>BTW, from my engineer point of view, I doubt we will be able to
>officially support it in CentOS 6. This requires a change in the
>kernel that depends on too many others (basically the whole HID
>stack). But this is not a Red Hat statement, just my wish that we
>should push back any request coming for this device on RHEL 6 :)
>

There's also the option of having an existing/new IRQ function in wacom_wac.c 
decode the reports without the benefit of HID like we currently do for such old 
input-wacom backports. Of course, it's fine to not bother with that until it 
becomes necessary.

Tangentially, I'd like data for this pair of devices added to the 
wacom-hid-descriptors repository. The sysinfo.sh script should be updated to 
detect the touch VID:PID first though.

Jason

>Cheers,
>Benjamin
>
>[2] https://patchwork.kernel.org/patch/10040899/
>
>>
>> Best,
>> Aaron
>>
>> [1]
>>
>https://sourceforge.net/p/linuxwacom/xf86-input-wacom/ci/b0a055425dfb983163b1d3c673a36aebf9536430/
>>>
>>> 2.13.6
>>>
>>>
>>>
>>>
>------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Linuxwacom-devel mailing list
>>> Linuxwacom-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
>>
>>


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to