On Tuesday, November 28, 2017, Jason Gerecke <killert...@gmail.com> wrote:
> C does not strictly allow allow an empty initializer
I like people to put efforts on cleaning up the code. It is a very
good habit, which we all should have ;).
Patches in this set, plus the individual one after this set, look good to
me. One nitpicking is: I don’t think you wanted to emphasize your idea by
double “allow” in the above line.
Reviewed-by: Ping Cheng <ping.ch...@wacom.com>
Cheers,
Ping
> list `{}`, which can
> result in missing-field-initializers warnings from the compiler. All
> consumers of this array cycle through until they see a NULL name, so
> this commit replaces the empty initializer with { .name = NULL }.
>
> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com <javascript:;>>
> ---
> tools/xsetwacom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c
> index 1051868..a94d1f9 100644
> --- a/tools/xsetwacom.c
> +++ b/tools/xsetwacom.c
> @@ -484,7 +484,7 @@ static param_t parameters[] =
> .get_func = get_all,
> .prop_flags = PROP_FLAG_READONLY,
> },
> - {}
> + {.name = NULL}
> };
>
> /**
> --
> 2.15.0
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
