On Tue, Mar 13, 2018 at 03:25:48PM -0700, Jason Gerecke wrote:
> If curl encounters an error trying to download the Coverity build script
> (as seems to be happening at the moment due to SSL issues), we will not
> be notified since the pipe swallows the error code. This is not ideal, so
> this commit updates the Travis build steps to use a slightly more contrived
> construction which will get and then execute the script as independent steps.
> Also, to ensure curl returns an error code even in less-severe cases (e.g. a
> basic 404 "Not Found") we add the '-f' option.
> 
> Signed-off-by: Jason Gerecke <jason.gere...@wacom.com>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>

Cheers,
   Peter
> 
> diff --git a/.travis.yml b/.travis.yml
> index 385c012..bc3f492 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -38,5 +38,5 @@ before_script:
>  
>  script:
>    - if [[ x"$TRAVIS_EVENT_TYPE" = "xcron" ]]; then export DO_COVERITY="YES"; 
> fi
> -  - if [[ x"$BUILDTYPE" = "xcoverity" && x"$DO_COVERITY" = "xYES" ]]; then 
> curl -s "$COVERITY_URL" | bash; fi
> +  - if [[ x"$BUILDTYPE" = "xcoverity" && x"$DO_COVERITY" = "xYES" ]]; then 
> COVERITY_SCRIPT=$(curl -fs "$COVERITY_URL") && echo "$COVERITY_SCRIPT" | 
> bash; fi
>    - if [[ x"$BUILDTYPE" != "xcoverity" ]]; then make CFLAGS="$CFLAGS" && 
> make check; fi
> -- 
> 2.16.2
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linuxwacom-devel mailing list
> Linuxwacom-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to