On Tue, Nov 16, 2010 at 03:05:08PM +0000, Marc Herbert wrote: > > Changes since livecd-tools-034: > > > Frederick Grose (4): > > Cleanup EOL spaces (#652522) > > Cleanup tabs (#652522) > > Set indentation to 4 spaces (#652522) > > Misc. fixups (#652522) > > > https://bugzilla.redhat.com/show_bug.cgi?id=652522 > > > > This is quite depressing. > > The price to pay for any reformatting is added noise in git log and > breakage of git blame, merge, apply,... to be weighed against the > better readability and consistency. > > In this specific case here the breakage is very wide (touching a vast > number of lines), and the readability improvement is... zero: > > https://bugzilla.redhat.com/attachment.cgi?id=460144&action=diff
It depends on your editor. Tabs are to be avoided in everything except Makefiles. And seriously, how often do you need to use git blame on livecd-tools? Brian -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgp5zEPj8cwYc.pgp
Description: PGP signature
-- livecd mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/livecd
