Stuart Bishop has proposed merging ~stub/canonical-livepatch-charm:use-venv
into canonical-livepatch-charm:master.
Requested reviews:
Barry Price (barryprice)
For more details, see:
https://code.launchpad.net/~stub/canonical-livepatch-charm/+git/canonical-livepatch-charm/+merge/332793
Per https://github.com/juju-solutions/charms.reactive/issues/135 , even charms
without wheelhouse dependencies can cause version conflicts with the
dependencies pulled in from the charms.reactive framework and other layers.
If we use the virtualenv option, this charm should never conflict.
The charm builds, but I have not tested it yet. In particular, it needs a test
upgrade from cs:canonical-livepatch to this version to ensure that switching
from a non-venv charm to a venv charm works smoothly.
I'll be doing a similar update to our other common reactive subordinates, and
PostgreSQL.
--
Your team Livepatch charm developers is subscribed to branch
canonical-livepatch-charm:master.
diff --git a/layer.yaml b/layer.yaml
index 6c38c40..ca4204e 100644
--- a/layer.yaml
+++ b/layer.yaml
@@ -4,6 +4,8 @@ includes:
- interface:nrpe-external-master
options:
basic:
+ use_venv: true
+ include_system_packages: true
packages:
# we need to specify these here due to https://github.com/juju-solutions/charms.reactive/issues/82
- build-essential
--
Mailing list: https://launchpad.net/~livepatch-charmers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~livepatch-charmers
More help : https://help.launchpad.net/ListHelp
