Review: Approve Looks good to me.
Diff comments: > diff --git a/reactive/canonical_livepatch.py b/reactive/canonical_livepatch.py > index f71923d..46f96e0 100644 > --- a/reactive/canonical_livepatch.py > +++ b/reactive/canonical_livepatch.py > @@ -1,5 +1,6 @@ > from charms import layer > -from charms.reactive import when, when_not, set_state, remove_state > +from charms.reactive import when, when_not, set_state, remove_state, > set_flag, clear_flag Better do a global search & replace while you are here, set_state -> set_flag, remove_state -> clear_flag > +from charms.reactive.flags import register_trigger > from charmhelpers.core.host import write_file, is_container > from charmhelpers.core import hookenv > from charmhelpers.contrib.charmsupport import nrpe -- https://code.launchpad.net/~barryprice/canonical-livepatch-charm/+git/canonical-livepatch-charm/+merge/347668 Your team Livepatch charm developers is subscribed to branch canonical-livepatch-charm:master. -- Mailing list: https://launchpad.net/~livepatch-charmers Post to : [email protected] Unsubscribe : https://launchpad.net/~livepatch-charmers More help : https://help.launchpad.net/ListHelp
