Unfortunately, adding ProcessElfCore and JITLoaderGDB to the cmake build isn't 'obvious', since ProcessElfCore replies on ProcessPOSIXLog.h, which is in the ProcessPOSIX plugin, which is also not built on Windows. I don't know if that plugin is supported on Windows, for remote debugging or not, so adding it would be premature.
Any advice would be appreciated. ---------------------------------------- > From: [email protected] > Date: Thu, 6 Mar 2014 15:36:55 -0800 > To: [email protected] > CC: [email protected] > Subject: Re: [Lldb-commits] [lldb] r203107 - Fix Windows build break > introduced in r203035. > > JITLoader and ProcessELFCore should be able to build on any system so that > you can use this functionality to do remote debugging. > > I reverted your patch with: > > % svn commit > Sending source/lldb.cpp > Transmitting file data . > Committed revision 203178. > > The real fix for Windows is to make sure it builds all that it needs to in > order to support ProcessElfCore and JITLoaderGDB. That probably means fixing > the Makefiles or CMakeList.txt files. > > On Mar 6, 2014, at 3:30 AM, Ahmed Charles <[email protected]> wrote: > >> Author: ace2001ac >> Date: Thu Mar 6 05:30:34 2014 >> New Revision: 203107 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=203107&view=rev >> Log: >> Fix Windows build break introduced in r203035. >> >> Add '#if defined(__linux__) || defined(__FreeBSD__)' around JITLoaderGDB >> and ProcessElfCore, which are only built on Linux and FreeBSD. >> >> Modified: >> lldb/trunk/source/lldb.cpp >> >> Modified: lldb/trunk/source/lldb.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/lldb/trunk/source/lldb.cpp?rev=203107&r1=203106&r2=203107&view=diff >> ============================================================================== >> --- lldb/trunk/source/lldb.cpp (original) >> +++ lldb/trunk/source/lldb.cpp Thu Mar 6 05:30:34 2014 >> @@ -124,8 +124,10 @@ lldb_private::Initialize () >> ScriptInterpreterPython::InitializePrivate(); >> OperatingSystemPython::Initialize(); >> #endif >> +#if defined(__linux__) || defined(__FreeBSD__) >> JITLoaderGDB::Initialize(); >> ProcessElfCore::Initialize(); >> +#endif >> >> #if defined (__APPLE__) >> //---------------------------------------------------------------------- >> @@ -208,9 +210,11 @@ lldb_private::Terminate () >> #ifndef LLDB_DISABLE_PYTHON >> OperatingSystemPython::Terminate(); >> #endif >> +#if defined(__linux__) || defined(__FreeBSD__) >> JITLoaderGDB::Terminate(); >> ProcessElfCore::Terminate(); >> - >> +#endif >> + >> #if defined (__APPLE__) >> DynamicLoaderMacOSXDYLD::Terminate(); >> DynamicLoaderDarwinKernel::Terminate(); >> >> >> _______________________________________________ >> lldb-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > > _______________________________________________ > lldb-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits > _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
