Deepak, >int items = bytesGot / reg_info->byte_size; Is this line assuming that all registers will be of same size?
Regards, Abid > -----Original Message----- > From: [email protected] [mailto:lldb-commits- > [email protected]] On Behalf Of Deepak Panickal > Sent: 25 July 2014 16:56 > To: [email protected] > Cc: [email protected]; [email protected]; lldb- > [email protected] > Subject: [Lldb-commits] [PATCH] Changes the hardcoded loading of ARM > registers to moved from gdb-remote and fixes an issue with the $g packet > where the data is thrown away with size mismatch > > Hi, > > - ARM registers were duplicated in both the ABI and the gdb-remote. This > patch removes them from gdb-remote and loads them from the ABI instead. > - The g packet response currently checks if the data size returned contains > all > registers. This patch fixes it such that if the data size returned is less > than > expected, it's still used with only those registers marked as valid. > > Thanks, > Deepak Panickal > > http://reviews.llvm.org/D4669 > > Files: > source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp > source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h > source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp _______________________________________________ lldb-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
