dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke the build on OSX Mavericks (appears to work fine on Yosemite).
After this commit, the lldb build now fails with:
...
../tools/lldb/tools/debugserver/source/MacOSX/MachTask.mm:452:41: error: use
of undeclared identifier 'vm_kernel_page_size'
static vm_size_t pagesize = vm_kernel_page_size;
^
../tools/lldb/tools/debugserver/source/MacOSX/MachTask.mm:470:60: error: use
of undeclared identifier 'vm_kernel_page_size'
uint64_t total_used_count = (physical_memory / vm_kernel_page_size)
- (vminfo.free_count - vminfo.speculative_count) - vminfo.external_page_count -
vminfo.purgeable_count;
...
Note: configured and built in llvm/build_ninja with :
cmake -G Ninja .. "-DLLVM_TARGETS_TO_BUILD=ARM;X86;AArch64"
-DCMAKE_CXX_FLAGS="-std=c++11 -stdlib=libc++" -DCMAKE_BUILD_TYPE=Debug
ninja lldb
clang --version is: Apple LLVM version 5.1 (clang-503.0.40)
uname -v is: Darwin Kernel Version 13.3.0: Tue Jun 3 21:27:35 PDT 2014;
root:xnu-2422.110.17~1/RELEASE_X86_64
Users:
dawn (Auditor)
http://reviews.llvm.org/rL240728
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits