jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This looks fine.  Please add a comment to the declaration of 
GetWatchpointHitAddress.  The meaning is really only explained in StopInfo.cpp, 
and I don't think the name is clear enough (we would say the watchpoint was NOT 
hit if the WatchpointHitAddress didn't equal the set address) to stand without 
some clarification.  Other than that it looks good.


Repository:
  rL LLVM

http://reviews.llvm.org/D11672




_______________________________________________
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Reply via email to