tberghammer added a subscriber: tberghammer.

================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:853
@@ -852,3 +852,3 @@
         if (platform_sp && platform_sp->IsConnected())
-            SetUnixSignals(platform_sp->GetUnixSignals());
+            
SetUnixSignals(std::make_shared<GDBRemoteSignals>(platform_sp->GetUnixSignals()));
         else
----------------
I think it would be better to change SetUnixSignals to create the copy (or 
force the client side copy with some magic with rvalue references) because this 
error will happen almost every time somebody calls SetUnixSignals.


http://reviews.llvm.org/D12420



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to