Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

[Tamas Berghammer via lldb-commits]

tberghammer retitled this revision from "Introduce new address class 
eAddressClassDataIntermixedCode" to "Use eAddressClassCode for address lookup 
for opcodes".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 33937.
tberghammer added a comment.

Address review comment


http://reviews.llvm.org/D12556

Files:
  source/Core/Address.cpp

Index: source/Core/Address.cpp
===================================================================
--- source/Core/Address.cpp
+++ source/Core/Address.cpp
@@ -371,7 +371,7 @@
 {
     addr_t code_addr = GetLoadAddress (target);
     if (code_addr != LLDB_INVALID_ADDRESS)
-        code_addr = target->GetOpcodeLoadAddress (code_addr, 
GetAddressClass());
+        code_addr = target->GetOpcodeLoadAddress (code_addr, 
eAddressClassCode);
     return code_addr;
 }
 
@@ -381,7 +381,7 @@
     if (SetLoadAddress (load_addr, target))
     {
         if (target)
-            m_offset = target->GetOpcodeLoadAddress (m_offset, 
GetAddressClass());
+            m_offset = target->GetOpcodeLoadAddress (m_offset, 
eAddressClassCode);
         return true;
     }
     return false;



Index: source/Core/Address.cpp
===================================================================
--- source/Core/Address.cpp
+++ source/Core/Address.cpp
@@ -371,7 +371,7 @@
 {
     addr_t code_addr = GetLoadAddress (target);
     if (code_addr != LLDB_INVALID_ADDRESS)
-        code_addr = target->GetOpcodeLoadAddress (code_addr, GetAddressClass());
+        code_addr = target->GetOpcodeLoadAddress (code_addr, eAddressClassCode);
     return code_addr;
 }
 
@@ -381,7 +381,7 @@
     if (SetLoadAddress (load_addr, target))
     {
         if (target)
-            m_offset = target->GetOpcodeLoadAddress (m_offset, GetAddressClass());
+            m_offset = target->GetOpcodeLoadAddress (m_offset, eAddressClassCode);
         return true;
     }
     return false;

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits