labath added a comment.

Looks good after fixing inverting one condition, but I would like to wait for 
an ok from zachary also. Linux builds fine after this patch.


================
Comment at: source/Host/common/GetOptInc.cpp:3
@@ +2,3 @@
+
+#if !defined(REPLACE_GETOPT) && !defined(REPLACE_GETOPT_LONG) && 
!defined(REPLACE_GETOPT_LONG_ONLY)
+
----------------
You have the logic reversed here. This should be #if defined(FOO) || 
defined(BAR) || defined(BAZ)


Repository:
  rL LLVM

http://reviews.llvm.org/D12582



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to