ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: source/Core/Module.cpp:1712
@@ -1712,1 +1711,3 @@
+ if (!FileSpec::Equal (file_spec, m_file,
(bool)file_spec.GetDirectory()) &&
+ !FileSpec::Equal (file_spec, m_platform_file,
(bool)file_spec.GetDirectory()))
return false;
----------------
It might expose some tricky problems when host and target have the same library
with the same path but different content.. - please make sure that there is no
regressions.
================
Comment at: source/Target/Platform.cpp:278
@@ +277,3 @@
+ if (error.Success() && module_sp)
+
module_sp->SetPlatformFileSpec(spec.GetFileSpec());
+ return error;
----------------
What do you think about putting
module_sp->SetPlatformFileSpec(spec.GetFileSpec()) into
ModuleList::GetSharedModule ?
http://reviews.llvm.org/D12601
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
